[libvirt] [PATCH v3 2/7] conf: Introduce new XML tag "mode" for disk source

[Daniel P. Berrange]

On Fri, Jul 19, 2013 at 08:32:28AM -0400, John Ferlan wrote:
> There are two ways to use a iSCSI LUN as disk source for qemu.
> 
>  * The LUN's path as it shows up on host, e.g.
>    /dev/disk/by-path/ip-$ip:3260-iscsi-$iqn-fc18:iscsi.iscsi0-lun-1
> 
>  * The libiscsi URI from the storage pool source element host attribute, e.g.
>    iscsi://demo.org:6000/iqn.1992-01.com.example/1
> 
> For a "volume" type disk, if the specified "pool" is of iscsi
> type, we should support to use the LUN in either of above 2 ways.
> That's why to introduce a new XML tag "mode" for the disk source
> (libvirt should support iscsi pool with libiscsi, but it's another
> new feature, which should be done later).
> 
> The "mode" can be either of "host" or "direct". Use "host" to indicate
> use of the LUN with the path as it shows up on host. Use "direct" to
> indicate to use it with the source pool host URI (future patches may support
> to use network type libvirt storage too, e.g. Ceph)
> ---
>  docs/formatdomain.html.in                          | 11 ++++-
>  docs/schemas/domaincommon.rng                      |  8 ++++
>  src/conf/domain_conf.c                             | 22 +++++++++-
>  src/conf/domain_conf.h                             | 22 ++++++++++
>  .../qemuxml2argv-disk-source-pool-mode.xml         | 48 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  1 +
>  6 files changed, 110 insertions(+), 2 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.xml

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|