[libvirt] [PATCH v5 0/5] Support CHAP authentication for iscsi pool

[John Ferlan]

This is a reworking and reposting of the authentication patches originally
posted as part of my v3 reworking of Osier's original patches, see:

https://www.redhat.com/archives/libvir-list/2013-July/msg00894.html

Patch 7/7 was noted to be incorrect since the authentication was in the
wrong place in the backend driver, see v3:

https://www.redhat.com/archives/libvir-list/2013-July/msg00901.html

and followups from my v2 posting:

https://www.redhat.com/archives/libvir-list/2013-July/msg00910.html

NOTE:
Patch 4 (https://www.redhat.com/archives/libvir-list/2013-July/msg00960.html)
was scrapped.

Adjustments from previous patches
1. Using the same logic as Direct iSCSI, add the pool authentication info
   from the iSCSI pool to virDomainDiskDef's during qemuTranslateDiskSourcePool
2. Refactor the secret fetching code into one function for easier use
3. Refactor the volume building code into one function for easier use. This
   is where the magic to add the auth information to the disk occurs and now
   that it's part of the disk definition from the pool it will just 'be there'
4. Restore original intent to use startPool callback in order to authenticate
   the pool.  Added a check for NULL connection.  This just stops autostarting
   pools from getting authentication. This still needs to be fixed/resolved,
   but there just wasn't time in this release for that.
5. Split the rbd authentication code into it's own patch rather than being
   part of the iscsi patch 4.
 
John Ferlan (5):
  qemu: Add source pool auth info to virDomainDiskDef for iSCSI
  qemu: Create a common qemuGetSecretString
  qemu_common: Create qemuBuildVolumeString() to process storage pool
  storage: Support "chap" authentication for iscsi pool
  Adjust 'ceph' authentication secret usage for rbd pool.

 src/qemu/qemu_command.c             | 265 ++++++++++++++++++++----------------
 src/qemu/qemu_conf.c                |  55 ++++++++
 src/storage/storage_backend_iscsi.c | 111 ++++++++++++++-
 src/storage/storage_backend_rbd.c   |  21 ++-
 4 files changed, 329 insertions(+), 123 deletions(-)

-- 
1.8.1.4