[libvirt] [PATCH v5 4/5] storage: Support "chap" authentication for iscsi pool

[John Ferlan]

On 07/23/2013 10:18 AM, Ján Tomko wrote:
> On 07/22/2013 10:31 PM, John Ferlan wrote:
> 
>> ---
>>  src/storage/storage_backend_iscsi.c | 111 +++++++++++++++++++++++++++++++++++-
>>  1 file changed, 110 insertions(+), 1 deletion(-)
>>
> 
> I can confirm this works, but it's a shame it doesn't work on autostart.
> 
> ACK if you clarify the error.
> 
> Jan
> 

The autostart changes require getting a connection to the secret
driver which I felt may take more time than I had to figure out
how to get to work properly...

In any case, I adjusted the message as follows (same in 5/5):

diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_i
index 388d6ed..ee8dd2e 100644
--- a/src/storage/storage_backend_iscsi.c
+++ b/src/storage/storage_backend_iscsi.c
@@ -714,7 +714,8 @@ virStorageBackendISCSISetAuth(const char *portal,
 
     if (!conn) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                       _("iscsi 'chap' authentication requires connection"));
+                       _("iscsi 'chap' authentication not supported "
+                         "for autostarted pools"));
         return -1;
     }


John