[libvirt] [PATCH] Support apparmor in RPM spec

Daniel P. Berrange berrange at redhat.com
Tue Jul 30 13:07:53 UTC 2013


On Tue, Jul 30, 2013 at 06:59:16AM -0600, Eric Blake wrote:
> On 07/30/2013 05:06 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange at redhat.com>
> > 
> > If libapparmor-devel happens to be installed when building the
> > RPM, it will failed due to unlisted virt-aa-helper in %files.
> > Add support for apparmor in the spec, so that we can explicitly
> > turn it on/off, defaulting to off in all distros. This causes
> > --without-apparmor to be given to configure, preventing the
> > build failures if the user happens to have libapparmor-devel
> > present.
> 
> Makes sense - we want the spec file to be absolute regardless of the
> dev's environment.
> 
> Question - is there a repo somewhere with libapparmor-devel built for
> Fedora, or does it remain something where I'm best off testing on a
> Debian-based build?

I took the SUSE libapparmor  source RPM and hacked it until
it would build on Fedora. Of course you can't actually
use it due to missing kernel support in Fedora, but it was
good enough to compile libvirt against.

Unfortunately I lost the hacked src.rpm I had when one of my
dev machines suffered fielsystem data loss :-(

It wasn't all that hard to hack the suse RPM though, so ought
to be fairly easy to recreate...

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list