[libvirt] [PATCH 1/3] Add space before the slash in dns srv entries

Ján Tomko jtomko at redhat.com
Wed Jul 31 11:41:42 UTC 2013


This matches the style for dhcp range/host and dns txt entries.

nat-network-dns-srv-record{,-minimal}.xml were only used by the
network schema test. This change allows them to be used unchanged
by network XML->XML test.
---
 src/conf/network_conf.c    | 2 +-
 tests/networkxml2xmltest.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index e3998f3..a0b543c 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -2281,7 +2281,7 @@ virNetworkDNSDefFormat(virBufferPtr buf,
             if (def->srvs[i].weight)
                 virBufferAsprintf(buf, " weight='%d'", def->srvs[i].weight);
 
-            virBufferAddLit(buf, "/>\n");
+            virBufferAddLit(buf, " />\n");
         }
     }
 
diff --git a/tests/networkxml2xmltest.c b/tests/networkxml2xmltest.c
index 0dfed16..bb8a9ad 100644
--- a/tests/networkxml2xmltest.c
+++ b/tests/networkxml2xmltest.c
@@ -103,6 +103,8 @@ mymain(void)
     DO_TEST("netboot-network");
     DO_TEST("netboot-proxy-network");
     DO_TEST("nat-network-dns-txt-record");
+    DO_TEST("nat-network-dns-srv-record");
+    DO_TEST("nat-network-dns-srv-record-minimal");
     DO_TEST("nat-network-dns-hosts");
     DO_TEST("8021Qbh-net");
     DO_TEST("direct-net");
-- 
1.8.1.5




More information about the libvir-list mailing list