[libvirt] [PATCH] virsh iface-bridge: Ignore delay if stp is turned off

Jiri Denemark jdenemar at redhat.com
Mon Jun 3 10:23:36 UTC 2013


Delay only makes sense with STP enabled.
---
 tools/virsh-interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index 1c2e40b..2bdb215 100644
--- a/tools/virsh-interface.c
+++ b/tools/virsh-interface.c
@@ -894,7 +894,7 @@ cmdInterfaceBridge(vshControl *ctl, const vshCmd *cmd)
         goto cleanup;
     }
 
-    if ((delay || stp) &&
+    if (stp &&
         ((virAsprintf(&delay_str, "%d", delay) < 0) ||
          !xmlSetProp(br_node, BAD_CAST "delay", BAD_CAST delay_str))) {
         vshError(ctl, _("Failed to set bridge delay %d in xml document"), delay);
-- 
1.8.2.1




More information about the libvir-list mailing list