[libvirt] [PATCH] qemuDomainGetVcpusFlags: Initialize ncpuinfo

Michal Privoznik mprivozn at redhat.com
Fri Jun 7 14:48:33 UTC 2013


Currently, there's a path to use the ncpuinfo variable uninitialized,
which leads to a compiler warning:

    qemu/qemu_driver.c: In function 'qemuDomainGetVcpusFlags':
    qemu/qemu_driver.c:4573:9: error: 'ncpuinfo' may be used
    uninitialized in this function [-Werror=maybe-uninitialized]
             for (i = 0; i < ncpuinfo; i++) {
             ^
---

Pushed under trivial & build-breaker rules.

 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e5f6988..c24f39c 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4512,7 +4512,7 @@ qemuDomainGetVcpusFlags(virDomainPtr dom, unsigned int flags)
     int ret = -1;
     virCapsPtr caps = NULL;
     qemuAgentCPUInfoPtr cpuinfo = NULL;
-    int ncpuinfo;
+    int ncpuinfo = -1;
     int i;
 
     virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
-- 
1.8.2.1




More information about the libvir-list mailing list