[libvirt] [PATCH] qemu_migrate: Dispose listen address if set from config

[Peter Krempa]

On 06/10/13 19:38, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=971485
>
> As of d7f9d827531bc843b7c5aa9d3e8c08738a1de248 we copy the listen
> address from the qemu.conf config file in case none has been provided
> via XML. But later, when migrating, we should not include such listen
> address in the migratable XML as it is something autogenerated, not
> requested by user. Moreover, the binding to the listen address will
> likely fail, unless the address is '0.0.0.0' or its IPv6 equivalent.
> This patch introduces a new boolean attribute to virDomainGraphicsListenDef
> to distinguish autofilled listen addresses. However, we must keep the
> attribute over libvirtd restarts, so it must be kept within status XML.
> ---
>   src/conf/domain_conf.c  | 28 ++++++++++++++++++++++++++++
>   src/conf/domain_conf.h  |  1 +
>   src/qemu/qemu_process.c |  1 +
>   3 files changed, 30 insertions(+)
>

ACK. I think it would be possible to add a test that would check the XML 
generator for this case so that it doesn't happen again. Have a look 
please if it's easy to do.

Peter