[libvirt] [PATCH v2] qemuDomainChangeGraphics: Check listen address change by listen type

[Jiri Denemark]

On Thu, Jun 20, 2013 at 19:43:30 +0200, Michal Privoznik wrote:
> Currently, we have a bug when updating a graphics device. A graphics device can
> have a listen address set. This address is either defined by user (in which case
> it's type is VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) or it can be inherited
> from a network (in which case it's type is
> VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK). However, in both cases we have a
> listen address to process (e.g. during migration, as I've tried to fix in
> 7f15ebc7).
> Later, when a user tries to update the graphics device (e.g. set a password),
> we check if listen addresses match the original as qemu doesn't know how to
> change listen address yet. Hence, users are required to not change the listen
> address. The implementation then just dumps listen addresses and compare them.
> Previously, while dumping the listen addresses, NULL was returned for NETWORK.
> After my patch, this is no longer true, and we get a listen address for olddev
> even if it is a type of NETWORK. So we have a real string on one side, the NULL
> from user's XML on the other side and hence we think user wants to change the
> listen address and we refuse it.
> 
> Therefore, we must take the type of listen address into account as well.
> ---
>  src/qemu/qemu_hotplug.c | 70 +++++++++++++++++++++++++++++++------------------
>  1 file changed, 44 insertions(+), 26 deletions(-)

ACK

Jirka