[libvirt] [PATCH 1/4] qemu: Improve info message and remove a variable in qemuDomainManagedSave
Daniel P. Berrange
berrange at redhat.com
Thu Jun 27 18:48:31 UTC 2013
On Wed, Jun 26, 2013 at 03:01:47PM +0200, Peter Krempa wrote:
> Mention the domain name that is being saved and remove the unneeded
> variable that only stores a constant.
> ---
> src/qemu/qemu_driver.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f51e766..23eb4fb 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -3118,7 +3118,6 @@ qemuDomainManagedSave(virDomainPtr dom, unsigned int flags)
> virDomainObjPtr vm;
> char *name = NULL;
> int ret = -1;
> - int compressed;
>
> virCheckFlags(VIR_DOMAIN_SAVE_BYPASS_CACHE |
> VIR_DOMAIN_SAVE_RUNNING |
> @@ -3144,10 +3143,10 @@ qemuDomainManagedSave(virDomainPtr dom, unsigned int flags)
> if (!(name = qemuDomainManagedSavePath(driver, vm)))
> goto cleanup;
>
> - VIR_INFO("Saving state to %s", name);
> + VIR_INFO("Saving state of domain '%s' to '%s'", vm->def->name, name);
>
> - compressed = QEMU_SAVE_FORMAT_RAW;
> - if ((ret = qemuDomainSaveInternal(driver, dom, vm, name, compressed,
> + if ((ret = qemuDomainSaveInternal(driver, dom, vm, name,
> + QEMU_SAVE_FORMAT_RAW,
> NULL, flags)) == 0)
> vm->hasManagedSave = true;
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list