[libvirt] [PATCH] add support for libssh2 password from auth file

[Peter Krempa]

On 06/27/13 14:31, David Maciejak wrote:
> Hi,
>
> I was discussing with Daniel about the best way to pass the ssh password
> when using such kind of uri:
> 'xen+libssh2://root at 192.168.0.10?sshauth=password
> <http://root@192.168.0.10?sshauth=password>'
>
> As it seems passing the password in the uri is not a good option, maybe we
> can grab it from auth conf ? it seems it's not the case as now (tell me
> if i am wrong).

I was planing on doing this stuff, but never managed to finish this.

>
> So enclosed a patch to add this feature.
>
> As you can see in virnetclient.c there is no virAuthGetPassword call, so
> the authfile is never used.
>
> The patch enclosed is modifying the function prototype to add
> virConnectPtr parameter (so remote_driver.c virNetClientNewLibSSH2 call
> has to be updated too and the corresponding .h too).
>
> Once we have access to virConnectPtr, as you will see in the patch we
> can check if authMethods is set to 'password' and grab the password from
> auth file by calling virAuthGetPassword.
>
>

please use git format-patch and send-email in the future, it makes 
reviewing easier.

See the attached patch for the review.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: virnetclient.patch
Type: text/x-diff
Size: 4714 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130628/a2f25089/attachment-0001.bin>