[libvirt] [PATCH 4/4] python: fix fd leak in generator.py

Guannan Ren gren at redhat.com
Fri Mar 1 07:42:17 UTC 2013


On 03/01/2013 06:26 AM, Eric Blake wrote:
> On 02/28/2013 03:03 AM, Guannan Ren wrote:
>> ---
>>   python/generator.py | 3 +++
>>   1 file changed, 3 insertions(+)
> At first, I was worried that this is a leak in the generated code.  But
> it looks like it is only a leak in the generator, and that the generated
> code is safe.  So it's not an essential bug fix, and more of a judgment
> call on whether to include in 1.0.3.  At any rate, the fix appears
> obvious enough that I'm fine giving:
>
> ACK.
>

    Thanks for this review.
    I pushed these two ack'ed patches before sending out another 
bug-fixing patch about generator.py.

    Guannan




More information about the libvir-list mailing list