[libvirt] [PATCH] qemu: fix wrong evaluation in qemuDomainSetMemoryParameters

Peter Krempa pkrempa at redhat.com
Mon Mar 4 17:30:41 UTC 2013


On 03/04/13 18:27, Satoru Moriya wrote:
> 19c6ad9a (qemu: Refactor qemuDomainSetMemoryParameters) introduced
> a new macro, VIR_GET_LIMIT_PARAMETER(PARAM, VALUE). But if statement
> in the macro is not correct and so set_XXXX flags are set to false
> in the wrong. As a result, libvirt ignores all memtune parameters.
> This patch fixes the conditional expression to work correctly.
>
> Signed-off-by: Satoru Moriya <satoru.moriya at hds.com>
> ---
>   src/qemu/qemu_driver.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
EW! :( Thanks for cathing this. ACK and will push soon.

Peter




More information about the libvir-list mailing list