[libvirt] [PATCH] rng: restrict passthrough names to known-good files
Eric Blake
eblake at redhat.com
Tue Mar 5 00:46:55 UTC 2013
On 03/04/2013 04:31 PM, Anthony Liguori wrote:
> Eric Blake <eblake at redhat.com> writes:
>
>> There is some controversy[1] on the qemu list on whether qemu should
>> have ever allowed arbitrary file name passthrough, or whether it
>> should be restricted to JUST /dev/random and /dev/hwrng. It is
>> always easier to add support for additional filenames than it is
>> to remove support for something once released, so this patch
>> restricts libvirt 1.0.3 (where the virtio-random backend was first
>> supported) to just the two uncontroversial names, letting us defer
>> to a later date any decision on whether supporting arbitrary files
>> makes sense. Additionally, since qemu 1.4 does NOT support
>> /dev/fdset/nnn fd passthrough for the backend, limiting to just
>> two known names means that we don't get tempted to try fd
>> passthrough where it won't work.
>
> Acked-by: Anthony Liguori <aliguori at us.ibm.com>
>
Thanks; I've pushed this into libvirt.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130304/f7c97874/attachment-0001.sig>
More information about the libvir-list
mailing list