[libvirt] [PATCH 2/3] libxl_driver: Resolve Coverity errors
Jim Fehlig
jfehlig at suse.com
Wed Mar 6 03:50:29 UTC 2013
Eric Blake wrote:
> On 03/05/2013 05:43 AM, John Ferlan wrote:
>
>> 1. The virObjectLock() call was unconditional, but Unlock was conditional
>> on vm being valid. Removed the check
>>
>> 2. A call to virDomainEventNewFromObj() isn't guaranteed to return an
>> event - that check needs to be made prior to libxlDomainEventQueue()
>> of the event. Did not add libxlDriverLock/Unlock around the call since
>> some callers already have lock taken
>>
>
> Someday, we should remove the big libxl lock in the same way that danpb
> just removed the big qemu lock; but that's an independent project.
>
Agreed. I added that to the libxl todo list when I saw his excellent work.
Jim
More information about the libvir-list
mailing list