[libvirt] [PATCH] Fix crash parsing RNG device specification

Peter Krempa pkrempa at redhat.com
Thu Mar 7 12:01:30 UTC 2013


On 03/07/13 12:58, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Code that validates the whitelist for the RNG device filename
> didn't account for fact that filename may be NULL. This led
> to a NULL reference crash. This wasn't caught since the test
> suite was not covering this XML syntax
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>   src/conf/domain_conf.c                             |  3 ++-
>   .../qemuxml2argv-virtio-rng-default.args           |  6 ++++++
>   .../qemuxml2argv-virtio-rng-default.xml            | 23 ++++++++++++++++++++++
>   tests/qemuxml2argvtest.c                           |  2 ++
>   4 files changed, 33 insertions(+), 1 deletion(-)
>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-default.args
>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-default.xml
>

ACK.

Peter




More information about the libvir-list mailing list