[libvirt] [PATCH 3/3] Convert QEMU driver to use virLogProbablyLogMessage

[Peter Krempa]

On 03/06/13 17:16, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> The current QEMU code for skipping log messages only skips over
> 'debug' message, switch to virLogProbablyLogMessage to make sure
> it skips over all of them
> ---
>   src/qemu/qemu_process.c | 12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 9f1507a..3196dbc 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c

...

>
> @@ -3764,6 +3755,7 @@ int qemuProcessStart(virConnectPtr conn,
>
>       if (unlink(priv->pidfile) < 0 &&
>           errno != ENOENT) {
> +        VIR_FREE(priv->pidfile);
>           virReportSystemError(errno,
>                                _("Cannot remove stale PID file %s"),
>                                priv->pidfile);

This hunk doesn't seem to be related to this patch. Also it would free 
the priv->pidfile argument right before reporting the error.

>

ACK with the last hunk removed.

Peter