[libvirt] [PATCH 7/7] Use VIR_MASS_CLOSE in LXC container startup

Peter Krempa pkrempa at redhat.com
Thu Mar 7 17:26:08 UTC 2013


On 03/07/13 17:41, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> In the LXC container startup code when switching stdio
> streams, we call VIR_FORCE_CLOSE on all FDs. This triggers
> a huge number of warnings, but we don't see them because
> stdio is closed at this point. strace() however shows them
> which can confuse people debugging the code. Switch to
> VIR_MASS_CLOSE to avoid this
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>   src/lxc/lxc_container.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

ACK.

PEter




More information about the libvir-list mailing list