[libvirt] [PATCH] nodeGetCellMemory is unused without numactl

Guido Günther agx at sigxcpu.org
Sat Mar 9 15:10:04 UTC 2013


make[3]: Entering directory `/var/scratch/debian/libvirt/upstream/libvirt/src'
  CC     libvirt_driver_la-nodeinfo.lo
nodeinfo.c:105:27: error: 'nodeGetCellMemory' declared 'static' but never defined [-Werror=unused-function]
cc1: all warnings being treated as errors
---
 src/nodeinfo.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index b80e389..26b269b 100644
--- a/src/nodeinfo.c
+++ b/src/nodeinfo.c
@@ -102,7 +102,9 @@ static int linuxNodeGetMemoryStats(FILE *meminfo,
                                    int cellNum,
                                    virNodeMemoryStatsPtr params,
                                    int *nparams);
+#if WITH_NUMACTL
 static unsigned long long nodeGetCellMemory(int cell);
+#endif
 
 /* Return the positive decimal contents of the given
  * DIR/cpu%u/FILE, or -1 on error.  If DEFAULT_VALUE is non-negative
@@ -1733,11 +1735,4 @@ unsigned long long nodeGetFreeMemory(virConnectPtr conn ATTRIBUTE_UNUSED)
                    _("NUMA memory information not available on this platform"));
     return 0;
 }
-
-static unsigned long long nodeGetCellMemory(int cell)
-{
-    virReportError(VIR_ERR_NO_SUPPORT, "%s",
-                   _("NUMA memory information not available on this platform"));
-    return 0;
-}
 #endif
-- 
1.7.10.4




More information about the libvir-list mailing list