[libvirt] [PATCH 06/13] qemu: support URI syntax for NBD
Paolo Bonzini
pbonzini at redhat.com
Mon Mar 11 13:21:56 UTC 2013
Il 11/03/2013 11:09, Osier Yang ha scritto:
>>
>> + if (!STREQ(uri->scheme, scheme)) {
>> + virReportError(VIR_ERR_INTERNAL_ERROR,
>> + _("Invalid transport/scheme '%s'"), uri->scheme);
>> + goto error;
>> + }
>
> How about uri->scheme is "gluster", and scheme is "nbd"? The error
> doesn't reflect the truth then.
>
> Except this and the coding style, all looks good.
The caller should guarantee that this does not happen.
Paolo
More information about the libvir-list
mailing list