[libvirt] [PATCH] Fix missing error dispatch in virDomainLxcEnterNamespace
Eric Blake
eblake at redhat.com
Tue Mar 12 17:53:24 UTC 2013
On 03/12/2013 11:37 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> The virDomainLxcEnterNamespace method mistakenly uses
> virCheckFlags, which returns immediately instead of
> virCheckFlagsGoto which jumps to the error cleanup
> patch where there is a virDispatchError call
> ---
> src/libvirt-lxc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
>
> diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c
> index c1bf168..abbbc12 100644
> --- a/src/libvirt-lxc.c
> +++ b/src/libvirt-lxc.c
> @@ -138,7 +138,7 @@ virDomainLxcEnterNamespace(virDomainPtr domain,
> {
> int i;
>
> - virCheckFlags(0, -1);
> + virCheckFlagsGoto(0, error);
>
> if (noldfdlist && oldfdlist) {
> size_t nfds;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130312/1f4a846c/attachment-0001.sig>
More information about the libvir-list
mailing list