[libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

Eric Blake eblake at redhat.com
Fri Mar 15 21:56:33 UTC 2013


On 03/15/2013 10:17 AM, Daniel P. Berrange wrote:
>> Ok to push 3-10 and 14 too?  Then I'll send the coding style adjustments
>> that Osier requested (but Dan acked nevertheless) and 11-13 which need a
>> bit more work.
> 
> Nope, not ok to push 7 or 8, given the way it represents IQN & LUN as
> separate attributes.

I've applied 3-6, but now I'm lost.  I didn't see negative comments on 7
or 8 - but did see a complaint on 9 which in turn had reply that 8 needs
a respin to not forbid '/'.  To play it safe, I will wait for a v2
respin of all remaining patches.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130315/0ec9933a/attachment-0001.sig>


More information about the libvir-list mailing list