[libvirt] [PATCH] qemu: Un-mark volume as mirrored/copied if blockjob copy fails

Peter Krempa pkrempa at redhat.com
Thu Mar 21 11:33:42 UTC 2013


On 03/20/13 18:24, Eric Blake wrote:
> On 03/20/2013 09:53 AM, Peter Krempa wrote:
>> When the blockjob fails for some reason an event is emitted but the disk
>> wasn't unmarked as being part of a active block copy operation.
>> ---
>>   src/qemu/qemu_process.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>> index 2465938..ada864b 100644
>> --- a/src/qemu/qemu_process.c
>> +++ b/src/qemu/qemu_process.c
>> @@ -970,6 +970,9 @@ qemuProcessHandleBlockJob(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
>>           if (disk->mirror && type == VIR_DOMAIN_BLOCK_JOB_TYPE_COPY &&
>>               status == VIR_DOMAIN_BLOCK_JOB_READY)
>>               disk->mirroring = true;
>> +        if (disk->mirror && type == VIR_DOMAIN_BLOCK_JOB_TYPE_COPY &&
>> +            status == VIR_DOMAIN_BLOCK_JOB_FAILED)
>> +            VIR_FREE(disk->mirror);
>
> ACK.
>

Pushed; Thanks.

Peter




More information about the libvir-list mailing list