[libvirt] [PATCH 2/3] conf: Use virMacAddrFormat while generating domain XML files

Eric Blake eblake at redhat.com
Wed Mar 27 21:45:50 UTC 2013


On 03/26/2013 08:06 AM, Martin Kletzander wrote:
> On 03/26/2013 12:26 PM, Peter Krempa wrote:
>> Format the address using the helper to avoid code duplication.
>> ---
>>  src/conf/domain_conf.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)

> I'd ACK that, fine use for the cleanup, but pity it's fixed on only one
> place.  How about squashing in the following?

The followup also looks fine.  Is this something you were planning on
pushing in 1.0.4?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130327/b6596900/attachment-0001.sig>


More information about the libvir-list mailing list