[libvirt] [libvirt-sandbox][PATCH v2] Avoid segfault in gvir_sandbox_config_add_host_include_file

Alex Jia ajia at redhat.com
Thu Mar 28 03:03:05 UTC 2013


On 03/27/2013 06:05 PM, Daniel P. Berrange wrote:
> On Mon, Mar 25, 2013 at 01:20:19PM +0800, Alex Jia wrote:
>> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=924574
>>
>> Valgrind defects memory error:
>>
>> ==19297== Invalid free() / delete / delete[] / realloc()
>> ==19297==    at 0x4A077A6: free (vg_replace_malloc.c:446)
>> ==19297==    by 0x350F24D79E: g_free (in /usr/lib64/libglib-2.0.so.0.3400.2)
>> ==19297==    by 0x4C2C03F: gvir_sandbox_config_add_host_include_file (libvirt-sandbox-config.c:1319)
>> ==19297==    by 0x401FB7: main (virt-sandbox.c:171)
>> ==19297==  Address 0x4f2094c is 12 bytes inside a block of size 18 alloc'd
>> ==19297==    at 0x4A0883C: malloc (vg_replace_malloc.c:270)
>> ==19297==    by 0x350F24D68E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3400.2)
>> ==19297==    by 0x350F263F0B: g_strdup (in /usr/lib64/libglib-2.0.so.0.3400.2)
>> ==19297==    by 0x4C2BF95: gvir_sandbox_config_add_host_include_file (libvirt-sandbox-config.c:1292)
>> ==19297==    by 0x401FB7: main (virt-sandbox.c:171)
>>
>> Signed-off-by: Alex Jia<ajia at redhat.com>
>> ---
>>   libvirt-sandbox/libvirt-sandbox-config.c |    7 +++++--
>>   1 files changed, 5 insertions(+), 2 deletions(-)
> ACK
>
> Daniel

Thanks and pushed now.




More information about the libvir-list mailing list