[libvirt] [libvirt-glib] gconfig: Fix gvir_config_domain_graphics_new_from_tree

Christophe Fergeau cfergeau at redhat.com
Wed May 1 17:56:35 UTC 2013


It does not handle the recently added
GVirConfigDomainGraphicsRdp and GVirConfigDomainGraphicsDesktop
classes.
---
 libvirt-gconfig/libvirt-gconfig-domain-graphics.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics.c
index 2b54b87..e42e0cc 100644
--- a/libvirt-gconfig/libvirt-gconfig-domain-graphics.c
+++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics.c
@@ -67,17 +67,13 @@ gvir_config_domain_graphics_new_from_tree(GVirConfigXmlDoc *doc,
     } else if (g_str_equal(type, "spice")) {
         gtype = GVIR_CONFIG_TYPE_DOMAIN_GRAPHICS_SPICE;
     } else if (g_str_equal(type, "rdp")) {
-        goto unimplemented;
+        gtype = GVIR_CONFIG_TYPE_DOMAIN_GRAPHICS_RDP;
     } else if (g_str_equal(type, "desktop")) {
-        goto unimplemented;
+        gtype = GVIR_CONFIG_TYPE_DOMAIN_GRAPHICS_DESKTOP;
     } else {
         g_debug("Unknown graphics node: %s", type);
         return NULL;
     }
 
     return GVIR_CONFIG_DOMAIN_DEVICE(gvir_config_object_new_from_tree(gtype, doc, NULL, tree));
-
-unimplemented:
-    g_debug("Parsing of '%s' graphics nodes is unimplemented", type);
-    return NULL;
 }
-- 
1.8.1.4




More information about the libvir-list mailing list