[libvirt] [libvirt-glib] Rename misnamed 'conn' variable everywhere

Daniel P. Berrange berrange at redhat.com
Wed May 1 18:47:49 UTC 2013


On Wed, May 01, 2013 at 07:56:54PM +0200, Christophe Fergeau wrote:
> Through copy and paste from libvirt-gobject-connection.c, we end
> up with an instance variable named 'conn' in most of our classes
> even if we are not manipulating a connection object. This commit
> renames it all 'conn' occurrences in libvirt-gobject and
> libvirt-gconfig with a name more consistent with the type of the
> variable named 'conn'.
> ---
>  .../libvirt-gconfig-domain-interface-bridge.c      |  6 ++---
>  .../libvirt-gconfig-domain-interface-network.c     |  6 ++---
>  .../libvirt-gconfig-domain-interface-user.c        |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-domain-snapshot.c  |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-domain.c           |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-interface.c        |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-network-filter.c   |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-network.c          |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-node-device.c      |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-object.c           | 12 +++++-----
>  libvirt-gconfig/libvirt-gconfig-secret.c           |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-storage-pool.c     |  6 ++---
>  libvirt-gconfig/libvirt-gconfig-storage-vol.c      |  6 ++---
>  libvirt-gobject/libvirt-gobject-domain-snapshot.c  | 20 ++++++++---------
>  libvirt-gobject/libvirt-gobject-domain.c           | 26 +++++++++++-----------
>  libvirt-gobject/libvirt-gobject-interface.c        | 20 ++++++++---------
>  libvirt-gobject/libvirt-gobject-manager.c          |  6 ++---
>  libvirt-gobject/libvirt-gobject-network-filter.c   |  6 ++---
>  libvirt-gobject/libvirt-gobject-network.c          | 20 ++++++++---------
>  libvirt-gobject/libvirt-gobject-node-device.c      | 20 ++++++++---------
>  libvirt-gobject/libvirt-gobject-secret.c           | 24 ++++++++++----------
>  libvirt-gobject/libvirt-gobject-storage-pool.c     |  4 ++--
>  libvirt-gobject/libvirt-gobject-storage-vol.c      | 20 ++++++++---------
>  23 files changed, 125 insertions(+), 125 deletions(-)

ACK

I am the king of copy+paste typos ;-)

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list