[libvirt] [PATCH] build: avoid useless virAsprintf
Eric Blake
eblake at redhat.com
Thu May 2 21:25:41 UTC 2013
On 05/02/2013 02:28 PM, Laine Stump wrote:
> On 05/02/2013 03:36 PM, Eric Blake wrote:
>> virAsprintf(&foo, "%s", bar) is wasteful compared to
>> foo = strdup(bar) (or eventually, VIR_STRDUP(foo, bar),
>> but one thing at a time...).
>>
>> Noticed while reviewing Laine's attempt to clean up broken
>> qemu:///session.
>
> Yeah, I noticed that too, and thought I had eliminated the one that was
> part of the patch, but I guess I just moved it instead :-/
>
>
> ACK.
Thanks; pushed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130502/9a5ef746/attachment-0001.sig>
More information about the libvir-list
mailing list