[libvirt] [PATCH] syntax-check: forbid virBufferAsprintf with string literals

Ján Tomko jtomko at redhat.com
Tue May 7 11:46:24 UTC 2013


---
 cfg.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index 1d63bbd..06f89d1 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -490,6 +490,11 @@ sc_prohibit_virBufferAdd_with_string_literal:
 	halt='use virBufferAddLit, not virBufferAdd, with a string literal' \
 	  $(_sc_search_regexp)
 
+sc_prohibit_virBufferAsprintf_with_string_literal:
+	@prohibit='\<virBufferAsprintf *\([^,]+, *"([^%"]|\")*"\)'		\
+	halt='use virBufferAddLit, not virBufferAsprintf, with a string literal' \
+	  $(_sc_search_regexp)
+
 # Not only do they fail to deal well with ipv6, but the gethostby*
 # functions are also not thread-safe.
 sc_prohibit_gethostby:
-- 
1.8.1.5




More information about the libvir-list mailing list