[libvirt] [PATCH 0/2] VIR_STRDUP ease of use
Eric Blake
eblake at redhat.com
Tue May 7 19:48:25 UTC 2013
On 05/07/2013 03:37 AM, Michal Privoznik wrote:
> On 07.05.2013 05:24, Eric Blake wrote:
>> As pointed out during my (ongoing) review of Michal's series, I
>> think that letting VIR_STRDUP take a NULL source can make it
>> easier to use; I also think that documenting the guarantee that
>> it evaluates arguments exactly once is worth enforcing.
>>
>> Hmm, I guess that means I should write a 3/2 patch that enhances
>> the testsuite to intentionally do a side effect and show that it
>> happens exactly once.
>>
>> Eric Blake (2):
>> alloc: make VIR_APPEND_ELEMENT safer
>> string: make VIR_STRDUP easier to use
>>
>> HACKING | 19 ++++++++++++-------
>> docs/hacking.html.in | 16 ++++++++++++----
>> src/util/viralloc.c | 9 ++++++---
>> src/util/viralloc.h | 36 +++++++++++++++++++++++++++---------
>> src/util/virstring.c | 12 ++++++++----
>> src/util/virstring.h | 22 ++++++++++++++++------
>> 6 files changed, 81 insertions(+), 33 deletions(-)
>>
>
> ACK series
Pushed, and I'm now working on a 3/2 patch for improving the testsuite.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130507/5967cc16/attachment-0001.sig>
More information about the libvir-list
mailing list