[libvirt] [PATCH v3 34/34] Introduce syntax-check rule to prefer VIR_STRDUP over strdup
Eric Blake
eblake at redhat.com
Thu May 9 17:13:44 UTC 2013
On 05/09/2013 04:39 AM, Michal Privoznik wrote:
>>>
>>> +exclude_file_name_regexp--sc_prohibit_strdup = \
>>> + ^(docs/|examples/|python/|src/util/virstring\.c$$|tools/virsh\.c$$)
>>
>> Do we really need to allow strdup() in the python c code? Likewise for
>> tools/virsh.c?
>
> Do you mean we should s/strdup/VIR_STRDUP/ within vshStrdup?
Might as well - it never hurts to be consistent in as many places as
possible.
>
> And I'll fix python surely.
>
> Michal
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130509/338541c1/attachment-0001.sig>
More information about the libvir-list
mailing list