[libvirt] [PATCH] Fix naming of methods in ESX storage backends to follow public APIs

Eric Blake eblake at redhat.com
Thu May 9 18:12:33 UTC 2013


On 05/09/2013 07:12 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The previous update of method naming missed the ESX storage
> backend files. Update them is that the driver impl methods
> follow the naming of the public API but with s/vir/esx/
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/esx/esx_storage_backend_iscsi.c | 104 ++++++++++++++++++------------------
>  src/esx/esx_storage_backend_vmfs.c  | 104 ++++++++++++++++++------------------
>  2 files changed, 104 insertions(+), 104 deletions(-)

ACK.  Mostly mechanical, and consistent with other patches.

Didn't you write a 'make check' rule that was supposed to catch
mismatches?  If so, doesn't that rule need to be updated to avoid
regressions in this file, since obviously this file escaped detection
the first time?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130509/8590c572/attachment-0001.sig>


More information about the libvir-list mailing list