[libvirt] BSD gcrypt warnings [was: [PATCH] build: mark conditionally unused variables]
Roman Bogorodskiy
bogorodskiy at gmail.com
Tue May 14 05:22:08 UTC 2013
Eric Blake wrote:
> On 05/13/2013 09:46 AM, Eric Blake wrote:
> > On 05/11/2013 08:27 AM, Roman Bogorodskiy wrote:
> >>>
> >>> The sad part is that we aren't even using the deprecated symbols - their
> >>> mere inclusion in the installed header is provoking the problems. It
> >>> looks like newer gcc is a bit more tolerant (that is, this is a
> >>> shortcoming of FreeBSD's use of an older compiler).
> >>>
> >
> >> I have tried this fix and it works for me:
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index 53f78de..4a813cc 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -1090,6 +1090,10 @@ if test "x$with_gnutls" != "xno"; then
> >> dnl it explicitly for the calls to gcry_control/check_version
> >> GNUTLS_LIBS="$GNUTLS_LIBS -lgcrypt"
> >>
> >> + dnl We're not using gcrypt deprecated features so define GCRYPT_NO_DEPRECATED
> >> + dnl to avoid deprecated warnings
> >> + GNUTLS_CFLAGS="$GNUTLS_CFLAGS -DGCRYPT_NO_DEPRECATED"
> >
> > Cool. I'm trying to get a Fedora rawhide VM going (since it has
> > libgcrypt-1.5.2) and verify that it works there as well, and then I'll
> > probably apply this as a formal patch in your name if I don't find any
> > issues in my testing.
>
> Now pushed. I'm still building with CFLAGS=-Wno-error to work past some
> other issues, but this one should now be fixed.
Thanks.
By the way, it builds fine with -Werror with clang with Daniel's
patches.
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130514/87b800bd/attachment-0001.sig>
More information about the libvir-list
mailing list