[libvirt] [PATCH 5/5] storage_conf: Improve the coding style in storage_conf.h
Osier Yang
jyang at redhat.com
Thu May 16 12:50:42 UTC 2013
On 16/05/13 20:40, Osier Yang wrote:
> Changes:
> * Remove useless comments
> * Remove useless blank lines
> * If the struct member is a enum type, comment it like
> /* enum fooBar */
> * Break the long lines
> * Prefer the common function style for the inline function
> ---
> src/conf/storage_conf.h | 120 ++++++++++++++++++++++++------------------------
> 1 file changed, 59 insertions(+), 61 deletions(-)
>
> diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
> index 567a4ac..4a1feb3 100644
> --- a/src/conf/storage_conf.h
> +++ b/src/conf/storage_conf.h
> @@ -30,11 +30,7 @@
>
> # include <libxml/tree.h>
>
> -/* Shared structs */
>
> -
> -
> -typedef struct _virStoragePerms virStoragePerms;
Accidently removed this line. With the following diff squashed in:
diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h
index 4a1feb3..8e739ff 100644
--- a/src/conf/storage_conf.h
+++ b/src/conf/storage_conf.h
@@ -30,7 +30,7 @@
# include <libxml/tree.h>
-
+typedef struct _virStoragePerms virStoragePerms;
typedef virStoragePerms *virStoragePermsPtr;
struct _virStoragePerms {
mode_t mode;
More information about the libvir-list
mailing list