[libvirt] [PATCH 1/3] lxc_process: Resolve Coverity NULL_RETURNS error
John Ferlan
jferlan at redhat.com
Thu May 16 14:51:34 UTC 2013
On 05/16/2013 10:19 AM, Eric Blake wrote:
> On 05/16/2013 08:01 AM, John Ferlan wrote:
>> In virLXCProcessReboot, if the 'conn' value is NULL, the eventual
>> call to virLXCNetworkLookupByName() via virLXCProcessStart() and
>> virLXCProcessSetupInterfaces() will cause a core since it references
>> conn->networkDriver directly.
>
> Did you investigate which commit introduced this problem?
yes, cb612ee4, when the function was created.
I will add it to the commit message
Given Daniel's response - is there a preference to perhaps add some sort
of message that conn was NULL from the virConnectOpen(). I would think
that the virLXCProcessStop() would still need to occur though, but also
wouldn't want to assume anything :-)
John
>
>> ---
>> src/lxc/lxc_process.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> ACK.
>
More information about the libvir-list
mailing list