[libvirt] [libvirt PATCH] conf: Fix the bug of disk->copy_on_read formating

[Osier Yang]

On 16/05/13 22:44, Ján Tomko wrote:
> On 05/14/2013 02:56 PM, Osier Yang wrote:
>> On 14/05/13 17:29, Ján Tomko wrote:
>>> On 05/14/2013 11:03 AM, Osier Yang wrote:
>>>> The reason for it's not exposed for such long time is that there is
>>>> no xml2xml test for it. This fixes the bug and adds test.
>>> It was not exposed, because virDomainVirtioEventIdx and
>>> virDomainDiskCopyOnRead enums are the same.
>> Oh, right,
>>
>>> Maybe we should use enum virDomainFeatureState for both instead?
>>>
>>>
>> It's something I planned to clean up, together with rng schemas. E.g.
>>
>>          <optional>
>>            <attribute name="dumpCore">
>>              <choice>
>>                <value>on</value>
>>                <value>off</value>
>>              </choice>
>>            </attribute>
>>          </optional>
>>
>> The principle is to define a common datatype and use it for all of the similar
>> attributes, same principle for  the enums in domain_conf.[ch].
>>
>> But anyway, it's another story, and this patch is a right fix.
>>
> Oh, sorry, I forgot to ACK it.
>
> ACK if you change the commit message so it doesn't imply that the test exposes
> the bug.
Thanks, I pushed with the commit log updated.

Osier