[libvirt] [PATCH 3/5] storage_conf: Various fixes or improvements on pool def parsing
Daniel P. Berrange
berrange at redhat.com
Mon May 20 11:29:58 UTC 2013
On Thu, May 16, 2013 at 08:40:52PM +0800, Osier Yang wrote:
> virStorageDefParsePerms:
> * Use uid_t/gid_t to do casting
Bug fix
>
> virStoragePoolDefParseSource:
> * Improve the error message for source "name" parsing
> * Remove the useless casting (const char *)
>
> virStoragePoolDefParseAuthChap:
> * Fix the wrong error message
Bug fix
>
> virStoragePoolDefParseAuthCephx:
> * Don't leak "uuid"
Bug fix
>
> virStoragePoolDefParseXML:
> * Remove the useless casting "(const char *)"
> * Use VIR_ERR_XML_ERROR for pool 'type' parsing
> * Remove the xmlFree()
> * s/tmppath/path/,
> * Create "virStoragePoolDefPtr def", and use ret to track the
> return value; frees the strings at "cleanup" label instead
> if freeing them in the middle.
> * Other small changes.
> ---
> src/conf/storage_conf.c | 169 ++++++++++++++++++++++++------------------------
> 1 file changed, 85 insertions(+), 84 deletions(-)
You've got a bunch of bug fixes & style cleanups all mixed together
here. We should have strict separation of bugs into individiual
patch, separate from any style changes.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list