[libvirt] [PATCH] conf: fix use after free in virChrdevOpen

Eric Blake eblake at redhat.com
Wed May 22 14:44:47 UTC 2013


On 05/22/2013 05:37 AM, Ján Tomko wrote:
> Don't free the stream on error if we've successfully added it
> to the hash table, since it will be freed by virChrdevHashEntryFree
> callback.
> 
> Preserve the error message before calling virStreamFree, since it
> resets the error.
> 
> Reported by Sergey Fionov on libvir-list.
> ---
>  src/conf/virchrdev.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)

ACK.  It might help if you track down which commit introduced the
problem and mention that in the commit message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130522/010b19c1/attachment-0001.sig>


More information about the libvir-list mailing list