[libvirt] [PATCH] conf: add missing OOM errors

Ján Tomko jtomko at redhat.com
Thu May 23 17:00:26 UTC 2013


---
Pushed under the trivial rule.

 src/conf/virchrdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index 17b1f05..36fbb97 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -89,8 +89,10 @@ static char *virChrdevLockFilePath(const char *dev)
         ++p;
     }
 
-    if (virAsprintf(&path, "%s/LCK..%s", VIR_CHRDEV_LOCK_FILE_PATH, filename) < 0)
+    if (virAsprintf(&path, "%s/LCK..%s", VIR_CHRDEV_LOCK_FILE_PATH, filename) < 0) {
+        virReportOOMError();
         goto cleanup;
+    }
 
     sanitizedPath = virFileSanitizePath(path);
 
@@ -136,8 +138,10 @@ static int virChrdevLockFileCreate(const char *dev)
 
     /* ensure correct format according to filesystem hierarchy standard */
     /* http://www.pathname.com/fhs/pub/fhs-2.3.html#VARLOCKLOCKFILES */
-    if (virAsprintf(&pidStr, "%10lld\n", (long long) getpid()) < 0)
+    if (virAsprintf(&pidStr, "%10lld\n", (long long) getpid()) < 0) {
+        virReportOOMError();
         goto cleanup;
+    }
 
     /* create the lock file */
     if ((lockfd = open(path, O_WRONLY | O_CREAT | O_EXCL, 00644)) < 0) {
-- 
1.8.1.5




More information about the libvir-list mailing list