[libvirt] [PATCH 3/3] virsh-domain: Add --live, --config, --current logic to cmdAttachInterface

Peter Krempa pkrempa at redhat.com
Tue May 28 15:33:07 UTC 2013


On 05/28/13 14:01, Guannan Ren wrote:
> On 05/28/2013 06:52 PM, Peter Krempa wrote:
>> Use the approach established in commit
>> 69ce3ffa8d431e9810607c6e00b7cfcc481b491d to improve this function too.
>> ---
>>   tools/virsh-domain.c | 59
>> +++++++++++++++++++++++++++++++++++-----------------
>>   tools/virsh.pod      | 34 +++++++++++++++++-------------
>>   2 files changed, 60 insertions(+), 33 deletions(-)
>
>> -Attach a new network interface to the domain.
>> -I<type> can be either I<network> to indicate a physical network
>> device or
>> -I<bridge> to indicate a bridge to a device.
>> -I<source> indicates the source device.
>> -I<target> allows to indicate the target device in the guest. Names
>> starting
>> -with 'vnet' are considered as auto-generated an hence blanked out.
>> -I<mac> allows to specify the MAC address of the network interface.
>> -I<script> allows to specify a path to a script handling a bridge
>> instead of
>> -the default one.
>> -I<model> allows to specify the model type.
>> -I<--config> indicates the changes will affect the next boot of the
>> domain,
>> -for compatibility purposes, I<--persistent> is alias of I<--config>.
>> -I<inbound> and I<outbound> control the bandwidth of the interface.
>> I<peak>
>> -and I<burst> are optional, so "average,peak", "average,,burst" and
>> +Attach a new network interface to the domain.  I<type> can be either
>> I<network>
>> +to indicate a physical network device or I<bridge> to indicate a
>> bridge to a
>> +device.  I<source> indicates the source device.  I<target> allows to
>> indicate
>> +the target device in the guest. Names starting with 'vnet' are
>> considered as
>> +auto-generated an hence blanked out.
>
>         Sorry the last sentence I can't quite follow it.

Hm. I actually didn't change the last sentence, I just reflowed the 
paragraph and deleted the sentence about --config and --persistent.

The last sentence means that if you use a interface name starting with 
'vnet' it will vanish as it's considered internal and autogenerated.

>
>         ACK with the rest.
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list