[libvirt] [PATCH 2/2] syntax-check: mandate space after mid-line semicolon

Eric Blake eblake at redhat.com
Tue May 28 15:47:02 UTC 2013


On 05/28/2013 09:28 AM, Osier Yang wrote:
> On 25/05/13 01:19, Eric Blake wrote:
>> Enforce the style cleanup in the previous patch.
>>
>> * build-aux/bracket-spacing.pl: Enforce trailing spacing.
>> * cfg.mk (bracket-spacing-check): Tweak error wording.
>> * docs/hacking.html.in: Document the rule.
>> * HACKING: Regenerate.
>>


>> +          (echo "$(ME): incorrect whitespace, see HACKING for rules"
>> && exit 1)
>>
> I see you changed this when pushing:
> 
> -          (echo $(ME): incorrect whitespace around brackets, see
> HACKING for rules && exit 1)
> +         { echo "$(ME): incorrect whitespace, see HACKING for rules"
> 2>&; \
> +           exit 1; }
> 
> But it breaks build. I guess you indented to write "2>&1" there.

Phooey.  I was trying to copy how we did it elsewhere, and copied wrong
without testing my final edit.  I'll push the fix shortly.  :(

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130528/f8460275/attachment-0001.sig>


More information about the libvir-list mailing list