[libvirt] [PATCH] qemu: snapshot: Don't kill access to disk if snapshot creation fails

Peter Krempa pkrempa at redhat.com
Fri May 31 14:06:10 UTC 2013


On 05/31/13 16:01, Eric Blake wrote:
> On 05/31/2013 07:45 AM, Peter Krempa wrote:
>> If snapshot creation failed for example due to invalid use of the
>> "REUSE_EXTERNAL" flag, libvirt killed access to the original image file
>> instead of the new image file. On machines with selinux this kills the
>> whole VM as the selinux context is enforced immediately.
>>
>> * qemu_driver.c:qemuDomainSnapshotUndoSingleDiskActive():
>>      - Kill access to the new image file instead of the old one.
>>
>> Partially resolves: https://bugzilla.redhat.com/show_bug.cgi?id=906639
>> ---
>>   src/qemu/qemu_driver.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> ACK, and okay for 1.0.6.
>

Pushed. Thanks.

Peter




More information about the libvir-list mailing list