[libvirt] [PATCH 0/2] Support setting the 'removable' flag for USB disks

Fred A. Kemp anonym at lavabit.com
Fri May 31 14:23:03 UTC 2013


From: "Fred A. Kemp" <anonym at lavabit.com>

For reference, my first attempt at a patch for this feature was:
<1363682454-32012-1-git-send-email-anonym at lavabit.com>

I believe this patch fixes all previous concerns raised that
thread. However, note that I've only added the new capability for
usb-storage.removable to the qemu help tests of qemu(-kvm) version
1.2.0, since that's what I had easily available to get the output of
`-device usb-storage,?` from.

Fred A. Kemp (2):
  qemu: Add capability flag for usb-storage
  qemu: Support setting the 'removable' flag for USB disks

 docs/formatdomain.html.in                          |    8 +++--
 docs/schemas/domaincommon.rng                      |    8 +++++
 src/conf/domain_conf.c                             |   31 ++++++++++++++++++--
 src/conf/domain_conf.h                             |    1 +
 src/qemu/qemu_capabilities.c                       |   10 +++++++
 src/qemu/qemu_capabilities.h                       |    2 ++
 src/qemu/qemu_command.c                            |   23 +++++++++++++--
 tests/qemuhelpdata/qemu-1.2.0-device               |   11 +++++++
 tests/qemuhelpdata/qemu-kvm-1.2.0-device           |   11 +++++++
 tests/qemuhelptest.c                               |   20 +++++++++----
 .../qemuxml2argv-disk-usb-device-removable.args    |    8 +++++
 .../qemuxml2argv-disk-usb-device-removable.xml     |   27 +++++++++++++++++
 tests/qemuxml2argvtest.c                           |    6 +++-
 13 files changed, 151 insertions(+), 15 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-usb-device-removable.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-usb-device-removable.xml

-- 
1.7.10.4





More information about the libvir-list mailing list