[libvirt] [PATCHv2 01/10] nodeinfo: Rename linuxNodeInfoCPUPopulate and export it properly
Peter Krempa
pkrempa at redhat.com
Mon Nov 4 10:15:18 UTC 2013
On 10/28/13 13:13, Daniel P. Berrange wrote:
> On Fri, Oct 18, 2013 at 05:05:41PM +0200, Peter Krempa wrote:
>> Call it virNodeInfoLinuxPopulateCPU and use the header file to export
>> it instead of extern definition in the test file.
>> ---
>> src/libvirt_linux.syms | 2 +-
>> src/nodeinfo.c | 14 +++++---------
>> src/nodeinfo.h | 5 +++++
>> tests/nodeinfotest.c | 6 +-----
>> 4 files changed, 12 insertions(+), 15 deletions(-)
>>
...
>
> I think it would be desirable to crate a nodeinfopriv.h header for
> this, since it isn't intended to be part of the internal API.
Hmm, I will send a new version of this one adding the new header when
finishing the refactor of nodeinfo.c
I've pushed the rest of the patches that were ACKed.
Thanks.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131104/7c1050aa/attachment-0001.sig>
More information about the libvir-list
mailing list