[libvirt] [PATCHv2 10/10] nodeinfo: Remove libnuma include

[Peter Krempa]

On 11/04/13 13:36, Ján Tomko wrote:
> On 10/18/2013 05:05 PM, Peter Krempa wrote:
>> Now that all libnuma functions used by libvirt are wrapped in virNuma we
>> can remove the dependancy from nodeinfo.
>> ---
>>  src/nodeinfo.c | 26 --------------------------
>>  1 file changed, 26 deletions(-)
>>

...

>>
> 
> This broke the build on FreeBSD:
> 
>   CC       libvirt_driver_la-nodeinfo.lo
> nodeinfo.c: In function 'virNodeGetSiblingsList':
> nodeinfo.c:1543: error: 'SYSFS_THREAD_SIBLINGS_LIST_LENGTH_MAX' undeclared
> (first use in this function)
> nodeinfo.c:1543: error: (Each undeclared identifier is reported only once
> nodeinfo.c:1543: error: for each function it appears in.)
> cc1: warnings being treated as errors
> nodeinfo.c: In function 'virNodeCapsFillCPUInfo':
> nodeinfo.c:1562: warning: implicit declaration of function 'virNodeGetCpuValue'
> nodeinfo.c:1562: warning: nested extern declaration of 'virNodeGetCpuValue'
> [-Wnested-externs]
> nodeinfo.c:1562: error: 'SYSFS_CPU_PATH' undeclared (first use in this function)
> make[3]: *** [libvirt_driver_la-nodeinfo.lo] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[3]: Leaving directory `/root/libvirt2/libvirt/src'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/root/libvirt2/libvirt/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/root/libvirt2/libvirt'
> make: *** [all] Error 2

Hmmm, nodeinfo.c is a convoluted mess of #ifdefs and platform specific
code. While factoring out the numa code I missed that this would enable
building some of that code on freebsd while some required functions are
protected by #ifdef __linux__.

I'll try to finish the split of nodeinfo.c into platform specific
subfiles. This should fix this issue.


> 
> Jan
> 

Thanks for pointing this out.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131104/10d82423/attachment-0001.sig>