[libvirt] [PATCH 1/2] Test if JSON parser fails on invalid input

Ján Tomko jtomko at redhat.com
Tue Nov 5 14:59:55 UTC 2013


---
 tests/jsontest.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/jsontest.c b/tests/jsontest.c
index 6add816..808a2ea 100644
--- a/tests/jsontest.c
+++ b/tests/jsontest.c
@@ -145,6 +145,10 @@ mymain(void)
 #define DO_TEST_PARSE(name, doc)                \
     DO_TEST_FULL(name, FromString, doc, NULL, true)
 
+#define DO_TEST_PARSE_FAIL(name, doc)           \
+    DO_TEST_FULL(name, FromString, doc, NULL, false)
+
+
     DO_TEST_PARSE("Simple", "{\"return\": {}, \"id\": \"libvirt-1\"}");
     DO_TEST_PARSE("NotSoSimple", "{\"QMP\": {\"version\": {\"qemu\":"
             "{\"micro\": 91, \"minor\": 13, \"major\": 0},"
@@ -188,6 +192,15 @@ mymain(void)
     DO_TEST_FULL("add and remove", AddRemove,
                  "[ 1 ]", NULL, false);
 
+
+    DO_TEST_PARSE_FAIL("nothing", "");
+    DO_TEST_PARSE_FAIL("number with garbage", "2345b45");
+    DO_TEST_PARSE_FAIL("float with garbage", "0.0314159ee+100");
+    DO_TEST_PARSE_FAIL("unterminated string", "\"The meaning of lif");
+    DO_TEST_PARSE_FAIL("object with numeric keys", "{ 1:1, 2:1, 3:2 }");
+    DO_TEST_PARSE_FAIL("array of an object with an array as a key",
+                       "[ {[\"key1\", \"key2\"]: \"value\"} ]");
+
     return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
 }
 
-- 
1.8.1.5




More information about the libvir-list mailing list