[libvirt] [PATCHv2] pci: properly handle out-of-order SRIOV virtual functions

Eric Blake eblake at redhat.com
Thu Nov 7 15:38:54 UTC 2013


On 11/07/2013 07:06 AM, Niilona wrote:
> Hi forget this as approach works using kernel-patch.
> Correctly was mentioned that the approach using leading-zeroes was a
> try to fix something happened in other place.
> Haven't get intention to libvirt side after that, wrote untested patch
> for this symptom.
> It's is not complete - no more error checking's.
> But it should pre-select only "virtfn" entries to be handled in
> while-loop, and after that scan through them in increasing numerical
> order.
> 
> Still, here it is :
> 
> < /* routine to select only "virtfn" -entries */
> < static int
> < virtfn_select(const struct dirent *entry)
> < {
> <     return (strncmp(entry->d_name,"virtfn", 6) == 0) ? 1 : 0;
> < }
> <
> 2401a2395,2396
>>     DIR *dir = NULL;
>>     struct dirent *entry = NULL;

Ouch.  This is an ed-script diff, which is practically worthless if we
don't know what version of the file to apply it to.  Can you please
resend as a proper context diff?  Also, please don't top-post on
technical lists.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131107/b40b1aed/attachment-0001.sig>


More information about the libvir-list mailing list