[libvirt] [PATCH] use -w flag if supported by iptables

Daniel P. Berrange berrange at redhat.com
Fri Nov 8 05:21:43 UTC 2013


On Thu, Nov 07, 2013 at 10:44:10AM -0600, Serge Hallyn wrote:
> Quoting Serge Hallyn (serge.hallyn at ubuntu.com):
> > Quoting Serge Hallyn (serge.hallyn at ubuntu.com):
> > > Quoting Laine Stump (laine at laine.org):
> > > > This needs to be "cmd = virCommandNew(.....);"
> > 
> > 
> > >From 1a43e48dfdc83fbde17d40351465af9031883595 Mon Sep 17 00:00:00 2001
> > From: Serge Hallyn <serge.hallyn at ubuntu.com>
> > Date: Thu, 31 Oct 2013 15:22:16 -0500
> > Subject: [PATCH 1/1] use -w flag if supported by iptables (v3)
> > 
> > Ask iptables to wait rather than fail if it is in use by another
> > caller (like ufw).
> > 
> > (See https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1245322)
> > 
> > Changelog:
> >    v2: take virIpTablesInitialize() out of HAVE_FIREWALLD ifdef.
> >    v3: make sure to set cmd to the result of virComandNew()
> 
> Hi - are there any other objections to this patch?

ACK from me.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list