[libvirt] [PATCHv3 6/6] qemu: process: Validate specific CPUID flags of a guest

Peter Krempa pkrempa at redhat.com
Fri Nov 8 09:26:56 UTC 2013


On 11/07/13 23:22, Jiri Denemark wrote:
> On Mon, Nov 04, 2013 at 14:55:07 +0100, Peter Krempa wrote:
>> When starting a VM the qemu process may filter out some requested
>> features of a domain as it's not supported either by the host or by
>> qemu. Libvirt didn't check if this happened which might end up in
>> changing of the guest ABI when migrating.
>>
>> The proof of concept implementation adds the check for the recently
>> introduced kvm_pv_unhalt cpuid feature bit. This feature depends on both
>> qemu and host kernel support and thus increase the possibility of guest
>> ABI breakage.
>> ---
>>
>> Notes:
>>     Version 3:
>>     - monitor code is now called only on the correct arch to avoid spurious errors in log
>>     
>>     Version 2:
>>     - adapted to previous changes
>>
>>  src/qemu/qemu_process.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 46 insertions(+)
> 
> ACK
> 
> Jirka

Thanks; I've fixed 2/6 and pushed the series.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131108/133e26d0/attachment-0001.sig>


More information about the libvir-list mailing list