[libvirt] [PATCH] Disable nwfilterDefineXML for unprivileged libvirtd

[Ján Tomko]

Fail in a more friendly way than:
error: cannot create config directory (null): Bad address

https://bugzilla.redhat.com/show_bug.cgi?id=1029266
---
 src/nwfilter/nwfilter_driver.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c
index 6602d73..c3ff4fe 100644
--- a/src/nwfilter/nwfilter_driver.c
+++ b/src/nwfilter/nwfilter_driver.c
@@ -551,13 +551,20 @@ nwfilterDefineXML(virConnectPtr conn,
                   const char *xml)
 {
     virNWFilterDriverStatePtr driver = conn->nwfilterPrivateData;
-    virNWFilterDefPtr def;
+    virNWFilterDefPtr def = NULL;
     virNWFilterObjPtr nwfilter = NULL;
     virNWFilterPtr ret = NULL;
 
     nwfilterDriverLock(driver);
     virNWFilterCallbackDriversLock();
 
+    if (!driver->privileged) {
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
+                       _("network filters are only available when libvirtd "
+                         "runs as root"));
+        goto cleanup;
+    }
+
     if (!(def = virNWFilterDefParseString(xml)))
         goto cleanup;
 
-- 
1.8.3.2